-
Notifications
You must be signed in to change notification settings - Fork 55
[Hotfix - 1.6.1 🔥 ] - Fix for double QR code issue #1945
Conversation
|
* missing wallet name issue fix * update wallet meta line
* added fix for balances not loading issue * small updates
version name is outdated, please change this to reflect the current prod version and make sure everything is up to date. have you properly tested this? can you provide detailed testing steps to make sure we catch any bugs and avoid what happened last time? @nenadV91 |
@nenadV91 , I have found an issue with MM wallet when connected with the app using WC: I can't get a signing confirmation modal in the MM. I reported an issue for the #1976 In addition, I get stuck import tokens modal when I connect to MM in XDAI using WC. The modal does not disappear until I press on the import button |
@elena-zh |
Hey @nenadV91 , changes LGTM besides an issue that is not related to this PR #1987 (co I can't test changes in Mainnet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side, code-wise seems alright to me. I would give my APPROVE if you get the approve from QA
I believe you have one unaddressed comment regarding 1inch
@anxolin I've posted about that in Slack https://gnosisinc.slack.com/archives/C025G521XQD/p1639403809006300, I don't have an iphone yet to debug this. I've tried browserstack but I think I need apple id to install new apps from the app store. |
should we close this? @nenadV91 |
I thought this one was in production. can you confirm @nenadV91? |
No, the issue is not in Prod. We could not release it due to 1Inch issue |
As Elena said this is not in Prod since there is still issue with 1inch wallet |
@nenadV91, i change this into develop branch for whenever we resume it |
@nenadV91 any update on this? |
@anxolin Nope, didn't work on it since we started working on claiming |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Summary
Fixes #1787
Fixes issues with double QR code by updating @web3-react/walletconnect-connector to new version and adding fix for some additional issues that occur after the update like missing balances and wallet info.
To test